-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust thickness values according to specification of an industrial product #1069
Conversation
for more information, see https://pre-commit.ci
Fix gas generators
add clipping to solid_biomass_potentials
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Martha Frysztacki <martha.frysztacki@gmail.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
set OCGT capacities from generators to links
for more information, see https://pre-commit.ci
…ities Set existing capacities
for more information, see https://pre-commit.ci
Make links non-extendable if not configured in config'
This reverts commit 0bd66d3.
Perhaps this was meant for a different branch? Reopen if that is not the case. I would suggest handling pull requests that do not target the master branch in a fork of PyPSA-Eur. This will make it a bit easier for me to keep an overview over what needs reviewing. Thanks! |
Yeah, indeed that was intended for chp_cc. Apologies and thanks a lot for checking @fneum! Agree that it feels weird to work from branches instead of fork. We'll try to figure out a better way. |
Thanks @fneum for flagging, this is more of a hirstoric ... diverge ... not sure. For future project we will definitely work on a fork, however, some of the features would be also nice to have also in PyPSA-Eur master branch. But we will most likely open smaller PRs and then delete this branch, or something like that |
Not saying anything against contributions to the master! That is most welcome! |
Changes proposed in this Pull Request
Regarding equivalent insulation thickness (
l_strength
in the code):l_strength
determined as 76 mm and 197 mm are in fact 3inch and 7.76 inch, respectivelly. The first value is perfectly reasonable according to Dupont product sheet, while for the second one I'd rather assume 7.5 inch = 3.5 inch + 4 inch = 190.5 mm.l_strength
according to the values ofl_weight
,Checklist
envs/environment.yaml
.config.default.yaml
.doc/configtables/*.csv
.doc/release_notes.rst
is added.