Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust thickness values according to specification of an industrial product #1069

Closed
wants to merge 70 commits into from

Conversation

ekatef
Copy link
Contributor

@ekatef ekatef commented May 18, 2024

Changes proposed in this Pull Request

Regarding equivalent insulation thickness (l_strength in the code):

  1. The thicknesses must be in fact in inches, as styrofoam is Canadian brand.
  2. Our inputs for l_strength determined as 76 mm and 197 mm are in fact 3inch and 7.76 inch, respectivelly. The first value is perfectly reasonable according to Dupont product sheet, while for the second one I'd rather assume 7.5 inch = 3.5 inch + 4 inch = 190.5 mm.
  3. Real insulation thickness values differ from l_strength according to the values of l_weight,

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

martacki and others added 30 commits January 12, 2024 14:36
add clipping to solid_biomass_potentials
yerbol-akhmetov and others added 25 commits April 23, 2024 22:29
Co-authored-by: Martha Frysztacki <martha.frysztacki@gmail.com>
set OCGT capacities from generators to links
Make links non-extendable if not configured in config'
@fneum
Copy link
Member

fneum commented May 19, 2024

Perhaps this was meant for a different branch? Reopen if that is not the case.

I would suggest handling pull requests that do not target the master branch in a fork of PyPSA-Eur. This will make it a bit easier for me to keep an overview over what needs reviewing. Thanks!

@fneum fneum closed this May 19, 2024
@ekatef
Copy link
Contributor Author

ekatef commented May 20, 2024

Perhaps this was meant for a different branch? Reopen if that is not the case.

I would suggest handling pull requests that do not target the master branch in a fork of PyPSA-Eur. This will make it a bit easier for me to keep an overview over what needs reviewing. Thanks!

Yeah, indeed that was intended for chp_cc. Apologies and thanks a lot for checking @fneum!

Agree that it feels weird to work from branches instead of fork. We'll try to figure out a better way.

@martacki
Copy link
Member

martacki commented May 21, 2024

Thanks @fneum for flagging, this is more of a hirstoric ... diverge ... not sure. For future project we will definitely work on a fork, however, some of the features would be also nice to have also in PyPSA-Eur master branch. But we will most likely open smaller PRs and then delete this branch, or something like that

@fneum
Copy link
Member

fneum commented May 21, 2024

Not saying anything against contributions to the master! That is most welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants