-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sector coupeled model for isolated non EU28 countries, e.g. UA #1110
Open
martacki
wants to merge
4
commits into
PyPSA:master
Choose a base branch
from
martacki:OS_UA_sec_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martacki
commented
Jun 20, 2024
Comment on lines
+1412
to
+1435
columns=[ | ||
"passenger cars", | ||
"passenger car efficiency", | ||
"total passenger cars", | ||
"total other road passenger", | ||
"total light duty road freight", | ||
"total two-wheel", | ||
"total heavy duty road freight", | ||
"electricity passenger cars", | ||
"electricity other road passenger", | ||
"electricity light duty road freight", | ||
"total rail passenger", | ||
"total rail freight", | ||
"electricity rail passenger", | ||
"electricity rail freight", | ||
"total domestic aviation passenger", | ||
"total domestic aviation freight", | ||
"total international aviation passenger", | ||
"total international aviation freight", | ||
"derived heat residential", | ||
"derived heat services", | ||
"thermal uses residential", | ||
"thermal uses services", | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't find a better way of doing this, suggestions appreciated
(maybe sth like
idees = build_idees(['DE'])
and then replacing all values by 0 or so could be better?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contents:
Just making the sec model run by filling missing sectoral data with defaults, average EU values or zeros, if nothing else is available. Thus, it currently has no real sectoral data, but allows the execution of the power model only in the sector coupeled style (i.e. adding distribution grids, solar thermal, etc.)
other comments:
experimenting to use git cherry-pick from OET/pypsa-eur fork to align our master branch with upstream ... (was this PR in OET fork open-energy-transition#1)... unfortunately used the wrong git commands, so that the history was lost
Checklist
envs/environment.yaml
.config.default.yaml
.doc/configtables/*.csv
.doc/release_notes.rst
is added.