Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ev battery master #1116

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rename ev battery master #1116

wants to merge 4 commits into from

Conversation

lindnemi
Copy link
Contributor

The old name is confusing. Only caveat: With this PR the Store has the exact same name as the bus. I don't think that's a problem but maybe there is a convention not to do that?

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@lindnemi
Copy link
Contributor Author

Related PyPSA/pypsa-ariadne#127

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change.

I think there are several instances where store has same carrier as bus.

@lindnemi
Copy link
Contributor Author

I think there are several instances where store has same carrier as bus.

yes, i saw that, but i was not worried about the carriers but the names (since i changed the suffixes to be the same)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants