Compatibility of data processing for Ukraine #1146
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Add_electricity.py from master branch breaks when "UA" is in the list of countries. This takes place in
attach_load()
function withKeyError: "['3118'] not in index"
. This is likely introduced by the recent update of polygon simplification defaults, see #1100What's happening: UA and MD have special keys of distributing load across regions (since the countries are not part of the NUTS system).
the ditribution keys were pre-computed here and stored as csv here
Data in
GDP_PPP_30arcsec_v3_mapped_default.csv
does not contain bus3118
, since it was likely filtered out with poligon simplification. See illustrations below.Another, more general problem: distribution keys should generally be part of the data workflow. With the incoming change of GridKit extract to OSM data (#1079), substation IDs will change and will be subject to frequent updates.
Suggestion
Checklist
envs/environment.yaml
.config.default.yaml
.doc/configtables/*.csv
.doc/release_notes.rst
is added.