New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNMY] Improve CI performance. #303
Conversation
mmh, still the about same time right? |
Windows seemed faster, but maybe that's just a fluke. Still I'm not happy about the environment setup taking 15-20 minutes. |
Using |
It should be always tied to the latest release (that's when we update the |
Some background info on why I am working on this atm: CI is sometime very slow (>> 20min runtime) and sometimes slowish (10-20 min runtime). I'm trying to figure out what the reason for this is, as installation locally is not that slow. The CI spends large parts of the runtime (and most of it if it is very slow) in the installation of packages. I came across an issue in the I'll continue tinkering a bit with it. The current version seems to run in ~5 min (Win, Linux) for dependency resolving+installation. That's significantly better performance. But we have already seen similar performance with the old |
ipopt availability under Windows for higher versions is not given.
Constraining package versions understandably improves the performance noticeably (74c8b35), but I don't think we should prefer this approach. |
can it be that the dask version constraint slows things? It is still |
From what I understand constraints on the versions should make the resolve step faster, not slower. So probably not. |
Ok, latest version looks promising: I am caching the resolved dependencies following the instructions provided by the The dependencies are now only resolved (= cache is updated) if:
Regarding performance:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! Thanks for going through all the effort! LGTM.
Would you like to squash it? If I do it, I think your contribution credit is lost. |
Will do! Thx! Before that, I nearly forgot: I removed two things from
Hope that's fine? |
Yes, sounds good! What's with the pending CIs? Does that come from the changed naming of CI runs? |
Yes, I believe that's due to renaming the runners. |
Ok, you do the honors @fneum . Because the name of the CI runners changed and the old ones are failing but compulsory, you (an Admin) has to disable them for the protected |
Done with updated branch protection rules :) |
👍 |
add option to use electrolysis waste heat in district heating
Idea I came across which might make the CI faster.
Changes proposed in this Pull Request
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes.