New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clustering strategies moved to configurables #380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, some comments below. Could we add build_year
, 'lifetime' and `efficiency'? Ideally with the functions as proposed here
pypsa-eur/scripts/cluster_network.py
Line 285 in bebbb00
'build_year': lambda x: 0, 'lifetime': lambda x: np.inf, |
and release notes of course |
Second! Could you also document the changes to the new and deleted config options here: https://github.com/PyPSA/pypsa-eur/blob/master/doc/configtables/clustering.csv and the removed https://github.com/PyPSA/pypsa-eur/blob/master/doc/configtables/onwind.csv#L12 https://github.com/PyPSA/pypsa-eur/blob/master/doc/configtables/solar.csv https://github.com/PyPSA/pypsa-eur/blob/master/doc/configtables/offwind-dc.csv https://github.com/PyPSA/pypsa-eur/blob/master/doc/configtables/offwind-ac.csv |
But the potential option is still needed for the build_renewables script, no? |
|
I think they cannot. But if we don't specify them, then PyPSA automatically will move to these defaults, so I wouldn't include it here. If you want to have a different aggregation, you can just add it now to your config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Pls don't merge, found sth I forgot. |
…e strats + include in stubaggregation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, just ping me when this is ready to be merged! Changes so far look good.
Sorry. I'll move duplicate code to _helpers script, because currently it's a 3x repetition |
Closes # (if applicable).
#375
Changes proposed in this Pull Request
all clustering strategies appearing in
cluster_network
orsimplify_network
now moved to configurables.very recent changes from #379 missing again, but need to be placed in the config now, instead of in any of the scripts. (also, #379 forgot to make the adaptations in
simplify_network
)Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes.