Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clustering strategies moved to configurables #380

Merged
merged 11 commits into from Jun 27, 2022

Conversation

martacki
Copy link
Member

@martacki martacki commented Jun 20, 2022

Closes # (if applicable).
#375

Changes proposed in this Pull Request

all clustering strategies appearing in cluster_network or simplify_network now moved to configurables.
very recent changes from #379 missing again, but need to be placed in the config now, instead of in any of the scripts. (also, #379 forgot to make the adaptations in simplify_network)

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes.

Copy link
Contributor

@FabianHofmann FabianHofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, some comments below. Could we add build_year, 'lifetime' and `efficiency'? Ideally with the functions as proposed here

'build_year': lambda x: 0, 'lifetime': lambda x: np.inf,
. But I don't know whether lamba's can be written in the yaml format...

scripts/simplify_network.py Outdated Show resolved Hide resolved
scripts/simplify_network.py Outdated Show resolved Hide resolved
@FabianHofmann
Copy link
Contributor

and release notes of course

@fneum
Copy link
Member

fneum commented Jun 21, 2022

@fneum
Copy link
Member

fneum commented Jun 21, 2022

But the potential option is still needed for the build_renewables script, no?
You're right.

@martacki
Copy link
Member Author

Love it, some comments below. Could we add build_year, 'lifetime' and `efficiency'? Ideally with the functions as proposed here

'build_year': lambda x: 0, 'lifetime': lambda x: np.inf,

. But I don't know whether lamba's can be written in the yaml format...

I think they cannot. But if we don't specify them, then PyPSA automatically will move to these defaults, so I wouldn't include it here. If you want to have a different aggregation, you can just add it now to your config.

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@martacki
Copy link
Member Author

Pls don't merge, found sth I forgot.

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just ping me when this is ready to be merged! Changes so far look good.

config.tutorial.yaml Outdated Show resolved Hide resolved
@fneum fneum enabled auto-merge June 27, 2022 12:06
@martacki martacki disabled auto-merge June 27, 2022 12:16
@martacki
Copy link
Member Author

Sorry. I'll move duplicate code to _helpers script, because currently it's a 3x repetition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants