Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcards option in config (full backward compatibility) #737

Merged
merged 20 commits into from
Jan 5, 2024

Conversation

virio-andreyana
Copy link
Collaborator

@virio-andreyana virio-andreyana commented Sep 11, 2023

Closes #729

Changes proposed in this Pull Request

Add wildcards options in config with full backward compatibility.

  • If the wildcard is given, then its value is used.
  • If the wildcard is not given but the options in config are available, then the value from config is used.
  • If neither is given, the the program should still work fine.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@virio-andreyana virio-andreyana marked this pull request as ready for review September 28, 2023 19:12
@fneum fneum merged commit f6fbd00 into master Jan 5, 2024
4 of 5 checks passed
@fneum fneum deleted the wildcard-opts-config branch January 5, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants