Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialogue to rule purge to prevent accidents #745

Merged
merged 27 commits into from Sep 28, 2023

Conversation

LukasFrankenQ
Copy link
Collaborator

Changes proposed in this Pull Request

Maybe this does not happen to more seasoned users, but whenever I use the model, I type something along the lines

snakemake -call --configfile config/config.yaml -- result...

If I slip, and press Enter early, I run snakemake -call, immediately triggering purge with known consequences. I imagine not being the only use to whom this might happen once upon a time.

This PR adds a simple dialogue, where the user can confirm via [y/N], if they actually would like to trigger purge.

PS: My local squash resists being pushed to GitHub, all --forceing does not help. Please feel free to squash if desired.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

LukasFrankenQ and others added 27 commits September 4, 2023 19:26
fix in add_heating_capacities_installed_before_baseyear to account for case when there is no rural heating demand for some nodes in network

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

simplify if-else expression

fix in co2_emissions_year function and correspondigly in plot_summary and snakemake rule. Also changes to historical_emissions in plot_summary since some countries are not in eea dataset.

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Update scripts/plot_summary.py

Co-authored-by: Fabian Hofmann <hofmann@fias.uni-frankfurt.de>

build_carbon_budget: parse input_co2

apply protected() to zenodo downloads; only retrieve monthly fuel/CO2 prices when necessary

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

added basic egs potential script

pre-testrun version added to prepare_sector_network

added new params to default config, and fixes

cleanup and renaming

changed default config to pessimism on egs

added minor cleanup correcting local adjustment

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

changed config name to egs_performant, added saturation check

cleanup of saturation check

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

added source for FOM

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

changed overlap indexing, general cleanup

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

added release notes

Fix bug preventing inclusion of custom_powerplants (PyPSA#732)

Fix a typo in the execution call

[pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/psf/black: 23.7.0 → 23.9.1](psf/black@23.7.0...23.9.1)

Move all rule to main Snakefile

Move all rule down to other rules

added dialogue to ensure desired purge

reverted to original pypsa-eur
@LukasFrankenQ LukasFrankenQ changed the title Add Dialogue to Rule purge to Prevent Accidents Add dialogue to rule purge to prevent accidents Sep 28, 2023
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Play it safe!

@fneum fneum merged commit 834f7ea into PyPSA:master Sep 28, 2023
4 of 5 checks passed
@LukasFrankenQ
Copy link
Collaborator Author

👍

@Irieo
Copy link
Contributor

Irieo commented Jan 5, 2024

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants