Python3 compatibility changes #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made small changes for python3 compatibility.
- The times could be off by 1 second, which causes the test to fail.
- Added stringOrNone() where missing. - Fixed some formatting.
- Changed cpdef for def's. - Updated signatures to be Py3 compatible. - Added unit tests.
- Removed pull_trigger function. As far as I can tell, this is only used by slurmctld, and is not an option in the strigger command. - Removed char* from function signature to make python 3 compatible. - Pass jobid as either string or int. - Changed cpdef's to def's. - Removed need for memset/memcpy - Various string encodings for Python3 compatibility.
- Added unit tests. - Python 3 compatibility changes. - Updated reservation example scripts.
- Updated examples for python3. - Added unit tests for create/update/delete partitions.
- Added unit test for node().update()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These batch of commits addresses issues #3 and #4, providing python 3 compatibility.