Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create OWN_TEAM Orientation #253

Open
DriesDeprest opened this issue Dec 7, 2023 · 3 comments
Open

Create OWN_TEAM Orientation #253

DriesDeprest opened this issue Dec 7, 2023 · 3 comments

Comments

@DriesDeprest
Copy link
Contributor

DriesDeprest commented Dec 7, 2023

I was thinking about adding support for an OWN_TEAM Orientation which in the case for an EventDataset would behave the same as the ACTION_EXECUTING_TEAM Orientation, but in the case of a TrackingDataset it would orient the coordinates of each player with respect to its own side. Implying that e.g. both goalkeepers would have a starting position of +- (0, 50).

What do you think @koenvo @JanVanHaaren ?

@koenvo
Copy link
Contributor

koenvo commented Dec 7, 2023

Sounds interesting. I'm planning to merge #190 first.

Curious what @probberechts thinks about your suggestions.

@probberechts
Copy link
Contributor

That sounds like a valuable feature! However, I would categorize it more as a symmetry transformation rather than an orientation change. In my conceptualization, orientation transforms merely switch perspectives without altering the underlying data, similar to changing the camera angle. On the other hand, symmetry transforms modify the relationships between data points.

So maybe we should create a different kind of transformation for this. There would be two such symmetry transformations: each team plays towards the same goal, and each action starts on the right side of the pitch. Combining both could be particularly useful, for instance, when analyzing corners it is common to aggregate them at a common point, like (0,0).

@JanVanHaaren
Copy link
Collaborator

Although I don't have much experience with orientations in kloppy, I like the proposal of @probberechts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants