New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing statsbomb shot outcome values #102

Merged

koenvo merged 1 commit into PySport:master from matiasb:statsbomb-deserializer-updates

Aug 11, 2021

Contributor

matiasb commented Aug 7, 2021 •

edited

I did a run of load_statsbomb_event_data of all the events data files in the open statsbomb dataset and ran into a couple of issues:

Missing shot outcome possible values:
- 115: saved off target
- 116: saved to post
duration may be missing for carry events

After these changes I can confirm the full statsbomb open dataset can be loaded without any issues.


          Add missing statsbomb shot outcome values

d3c4fec

koenvo merged commit c4ebd4e into PySport:master

Contributor

koenvo commented Aug 11, 2021

Thanks a lot @matiasb! Awesome test you did!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment