Do not create a temporary array when obj is not specified in create_array #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging version v.3.1.0
| # array fast and without memory consumption | ||
| dflt = numpy.zeros((), dtype=atom.dtype) | ||
| obj = numpy.ndarray(shape, dtype=atom.dtype, buffer=dflt, | ||
| strides=(0,)*len(shape)) |
There was a problem hiding this comment.
Interesting. Is this a known numpy bug?
There was a problem hiding this comment.
Known bug? Strides = (0, ...) are well supported in NumPy, although not advertised a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution for avoiding the creation of temporaries when creating a regular Array object when specifying the atom and shape only. Fixes #337.
Memory consumption is now similar to h5py, and by running the examples in this post (but with n = 50000 to make things a bit faster), we get:
with h5py:
with PyTables:
which is pretty much faster than h5py (don't know exactly why).