Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #177 still appears broken for frozen apps #675

Closed
jwiggins opened this issue Mar 16, 2018 · 2 comments
Closed

Fix for #177 still appears broken for frozen apps #675

jwiggins opened this issue Mar 16, 2018 · 2 comments

Comments

@jwiggins
Copy link
Contributor

The relevant PyInstaller issue is here: pyinstaller/pyinstaller#3407

I believe the original suggestion in #177 to skip the find_library checks in https://github.com/PyTables/PyTables/blob/develop/tables/__init__.py#L26-L86 would be better for frozen apps. Ideally, testing on an un-frozen version should have already established that the HDF5 library is correctly installed.

PyInstaller is doing some monkey patching which interacts badly with PyTables, which I pointed out in the above linked issue. Again, just skipping the check when sys.frozen is True would bypass the problem.

@tomkooij
Copy link
Contributor

@jwiggins : Let's just fix this. Can you provide a PR with that original fix from #177 implemented (again)? LGTM.

@jwiggins
Copy link
Contributor Author

@tomkooij Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants