New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foreign b2nd array compatibility #1072
Commits on Oct 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5d79cd4 - Browse repository at this point
Copy the full SHA 5d79cd4View commit details -
Mention B2ND in errors when reading chunk slices from the file
To avoid confusion with the HDF5 array dataset itself.
Configuration menu - View commit details
-
Copy full SHA for 6051655 - Browse repository at this point
Copy the full SHA 6051655View commit details -
Note on why a b2nd-specific case is needed in filter decompression
Thanks to @martaiborra for the clarification.
Configuration menu - View commit details
-
Copy full SHA for 8cd8559 - Browse repository at this point
Copy the full SHA 8cd8559View commit details -
Relax filter check for shape of b2nd array used to store a chunk
Instead of checking that the array's chunk shape matches the dataset's chunk shape, check that the array's whole shape matched the dataset's chunk shape. PyTables stores one Blosc2 chunk per HDF5 chunk, but it should be able to cope with Blosc2 frames containing several chunks (since reading does not really operate at the Blosc2 chunk level), as long as the whole Blosc2 array has the proper shape. This may ease having PyTables read b2nd-compressed arrays where dataset chunks contain several Blosc2 chunks.
Configuration menu - View commit details
-
Copy full SHA for 44178b3 - Browse repository at this point
Copy the full SHA 44178b3View commit details -
Check rank & shape of b2nd array when getting a slice
These checks were already made by the filter, but still missing here.
Configuration menu - View commit details
-
Copy full SHA for 78e1b39 - Browse repository at this point
Copy the full SHA 78e1b39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 942d2db - Browse repository at this point
Copy the full SHA 942d2dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d691de - Browse repository at this point
Copy the full SHA 5d691deView commit details -
Relax filter checks for b2nd array shape with no aux filter values
This increases compatibility with datasets written with other tools, esp. if they also use b2nd for scalar or unidimensional data, as chunk rank/shape filter values used by PyTables for the checks may be missing (and filter set function would not set them either since rank < 2).
Configuration menu - View commit details
-
Copy full SHA for 93d61a0 - Browse repository at this point
Copy the full SHA 93d61a0View commit details
Commits on Oct 19, 2023
-
Remove workaround for stack smashing/segmentation fault on GCC+Linux
The issue seems to have vanished on Guix (GCC 12.3.0), let us see what CI says about Ubuntu.
Configuration menu - View commit details
-
Copy full SHA for e16edd5 - Browse repository at this point
Copy the full SHA e16edd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6b47e1 - Browse repository at this point
Copy the full SHA c6b47e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ba4e78 - Browse repository at this point
Copy the full SHA 3ba4e78View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5536db - Browse repository at this point
Copy the full SHA d5536dbView commit details