Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use of system blosc2 to build pytables #987

Merged
merged 3 commits into from Dec 30, 2022

Conversation

avalentino
Copy link
Member

@avalentino avalentino commented Dec 29, 2022

Closes #986.
Closes #984.

Copy link
Contributor

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It seems to work fine for us. LGTM modulo the typo (but I don't know about Conda).

setup.py Outdated Show resolved Hide resolved
Co-authored-by: Michał Górny <mgorny@gentoo.org>
@avalentino
Copy link
Member Author

Thanks @mgorny

@FrancescAlted
Copy link
Member

Looks good to me. In the future, I'd like to strictly require python-blosc2 for allowing the registration of user-defined codecs and filters straight from Python, and hence, accessible from PyTables. But that will be next year, the soonest ;-)

@avalentino
Copy link
Member Author

Thanks @FrancescAlted.
Probably switching to a build system based on cmake or meson would help a lot in our case.
This is something that I had in mind singe very long time, probably it is time to start thinking to it more seriously.

Do you have experience with scikit-build or meson? ... or any other alternative?

@avalentino avalentino merged commit a166e66 into PyTables:master Dec 30, 2022
@avalentino avalentino deleted the feature/system-blosc2 branch December 30, 2022 11:10
@mgorny
Copy link
Contributor

mgorny commented Dec 30, 2022

My experience with scikit-build is one of pure horror and revulsion, please don't do that. meson on the other hand can be quite good, especially with meson-python PEP517 backend. There are some rough edges, particularly regarding installing pkg-config files and other data that doesn't fit cleanly inside a venv but I don't think any of that applies to PyTables.

@avalentino
Copy link
Member Author

@mgorny do you know other alternatives it that could worth to consider?

@mgorny
Copy link
Contributor

mgorny commented Dec 30, 2022

I could joke autotools but you probably don't want to do that ;-). No, I think meson is the state of art right now, as far as build systems are concerned, and it's getting first-class support from a lot of people right now, so if you hit any problems there's a good chance someone will provide a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants