New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use of system blosc2 to build pytables #987
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It seems to work fine for us. LGTM modulo the typo (but I don't know about Conda).
Thanks @mgorny |
Looks good to me. In the future, I'd like to strictly require python-blosc2 for allowing the registration of user-defined codecs and filters straight from Python, and hence, accessible from PyTables. But that will be next year, the soonest ;-) |
Thanks @FrancescAlted. Do you have experience with scikit-build or meson? ... or any other alternative? |
My experience with scikit-build is one of pure horror and revulsion, please don't do that. meson on the other hand can be quite good, especially with meson-python PEP517 backend. There are some rough edges, particularly regarding installing pkg-config files and other data that doesn't fit cleanly inside a venv but I don't think any of that applies to PyTables. |
@mgorny do you know other alternatives it that could worth to consider? |
I could joke autotools but you probably don't want to do that ;-). No, I think meson is the state of art right now, as far as build systems are concerned, and it's getting first-class support from a lot of people right now, so if you hit any problems there's a good chance someone will provide a good solution. |
Closes #986.
Closes #984.