NER: Add html-like tag in output #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @wannaphongcom! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-08-31 10:21:42 UTC |
p16i
reviewed
Aug 31, 2019
|
|
||
| return [(self.__pos_tags[i][0], data) for i, data in enumerate(self.__y)] |
There was a problem hiding this comment.
It would be good if we have tests for this change.
added 2 commits
August 31, 2019 16:30
changes in this commit: - assert the output of the method `get_ner` when argument `tag` is set to True for all 13 tags as described in (https://github.com/wannaphongcom/thai-ner/tree/master/model/1.2) - assert the output of the method `get_ner` when argument `pos` is set to True - asser the output of the method `get_ner` when argument `pos` is set to False
p16i
reviewed
Aug 31, 2019
tests/test_tag.py
Outdated
|
|
||
| self.assertEqual( | ||
| ner.get_ner( | ||
| "อาจารย์เอกพล ประจำคณะวิสกรรมศาสตร์ ", |
There was a problem hiding this comment.
Oh, yes. Thanks for checking the typos.
|
Apart from the typo, the PR looks good to me. |
added 2 commits
August 31, 2019 16:48
As thainer version 1.2 provide different results from previous version
|
if this pull request is ready, you can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add output like html tag (ThaiNameTagger).