Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port PerceptronTagger to PyThaiNLP #470

Merged
merged 18 commits into from
Aug 25, 2020
Merged

Port PerceptronTagger to PyThaiNLP #470

merged 18 commits into from
Aug 25, 2020

Conversation

wannaphong
Copy link
Member

@wannaphong wannaphong commented Aug 21, 2020

@wannaphong wannaphong requested a review from bact August 21, 2020 17:14
@pep8speaks
Copy link

pep8speaks commented Aug 21, 2020

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-23 19:36:02 UTC

@wannaphong wannaphong changed the title Port PerceptronTagger to PyThaiNLP [WIP] Port PerceptronTagger to PyThaiNLP Aug 21, 2020
@coveralls
Copy link

coveralls commented Aug 21, 2020

Coverage Status

Coverage increased (+0.2%) to 95.422% when pulling 89d4282 on add-perceptron-tagger into 44a818e on dev.

@wannaphong
Copy link
Member Author

@bact
Copy link
Member

bact commented Aug 22, 2020

Train Notebook : https://colab.research.google.com/drive/1iz4aRLBmyA_q9CY5P4zHmPG_v5iOaWgH?usp=sharing

can change

from pythainlp.tag._tag_perceptron import PerceptronTagger

to

from pythainlp.tag import PerceptronTagger

@wannaphong wannaphong changed the title [WIP] Port PerceptronTagger to PyThaiNLP Port PerceptronTagger to PyThaiNLP Aug 23, 2020
@wannaphong wannaphong added this to the 2.3 milestone Aug 23, 2020
@bact bact added the enhancement enhance functionalities label Aug 23, 2020
@bact bact added this to In progress in PyThaiNLP Aug 23, 2020
Copy link
Member

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updating the model training notebook, and I think we are good to go.

@wannaphong
Copy link
Member Author

Just updating the model training notebook, and I think we are good to go.

OK. I updating the model training notebook. https://colab.research.google.com/drive/1iz4aRLBmyA_q9CY5P4zHmPG_v5iOaWgH?usp=sharing

Copy link
Member

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go

@bact bact merged commit f98d18c into dev Aug 25, 2020
PyThaiNLP automation moved this from In progress to Done Aug 25, 2020
@bact bact deleted the add-perceptron-tagger branch August 26, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhance functionalities
Projects
PyThaiNLP
  
Done
Development

Successfully merging this pull request may close these issues.

perception/orchid_ud pos tagger model still require nltk to load
4 participants