-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port PerceptronTagger to PyThaiNLP #470
Conversation
Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-08-23 19:36:02 UTC |
can change
to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updating the model training notebook, and I think we are good to go.
OK. I updating the model training notebook. https://colab.research.google.com/drive/1iz4aRLBmyA_q9CY5P4zHmPG_v5iOaWgH?usp=sharing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go
from #468, I port PerceptronTagger class to PyThaiNLP.
Convert model: https://colab.research.google.com/drive/1mIFI39muLil3GckC_w2haoRrNEg606Xg?usp=sharing
Train model: https://colab.research.google.com/drive/1iz4aRLBmyA_q9CY5P4zHmPG_v5iOaWgH?usp=sharing
This will close #468