Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import #533

Closed
wants to merge 3 commits into from
Closed

Update import #533

wants to merge 3 commits into from

Conversation

wannaphong
Copy link
Member

What does this changes

I changed import on PyThaiNLP 2.2.

What was wrong

Prevents problems of importing duplicate files that are contained in pythainlp.

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@coveralls
Copy link

coveralls commented Jan 31, 2021

Coverage Status

Coverage remained the same at 95.466% when pulling 9532cb0 on update-import-2.2 into 590e24d on 2.2.

@pep8speaks
Copy link

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 39:1: E402 module level import not at top of file
Line 40:1: E402 module level import not at top of file
Line 41:1: E402 module level import not at top of file
Line 42:1: E402 module level import not at top of file
Line 49:1: E402 module level import not at top of file
Line 50:1: E402 module level import not at top of file

@wannaphong wannaphong closed this Feb 24, 2021
@wannaphong wannaphong deleted the update-import-2.2 branch March 18, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants