switch PyThaiNLP source code to SPDX license ID #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavaris-pm
commented
Dec 3, 2023
pythainlp/__init__.py
Outdated
Comment on lines
1
to
3
| # -*- coding: utf-8 -*- | ||
| # PyThaiNLP: Thai Natural Language Processing in Python | ||
| # | ||
| # Copyright (C) 2016-2023 PyThaiNLP Project | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # SPDX-FileCopyrightText: Copyright (C) 2016-2023 PyThaiNLP Project. | ||
| # SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
@bact here is an example of the change i've made according to your issue krub.
|
Thank a lot @pavaris-pm . This is so fast. Do you mind to changes two things please?:
(I decided to follow template in SPDX website)
Thank you. |
Roger that, I will add it accordingly within today krub. |
|
Kudos, SonarCloud Quality Gate passed!聽 聽
|
|
@bact i already add and update according to your review. please review my latest push krub. |
pavaris-pm
commented
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
According to issue #874 , in this PR, i already switch the license to SPDX already by replacing it with the new one as mentioned in that issue krub. Tag @bact since i have made changes and you are an issue owner. You can take a review at it and inform me if i miss something in the source code krub.
Fix #874
Your checklist for this pull request
馃毃Please review the guidelines for contributing to this repository.