Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pythainlp.util.morse #891

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Add pythainlp.util.morse #891

merged 6 commits into from
Dec 15, 2023

Conversation

wannaphong
Copy link
Member

@wannaphong wannaphong commented Dec 12, 2023

Add pythainlp.util.morse to encoder and decoder Morse code (Thai and English) for time traveler, historian, and Interested people.

Your checklist for this pull request

馃毃Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Dec 12, 2023

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP聽8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 馃嵒

Comment last updated at 2023-12-13 08:05:16 UTC

@coveralls
Copy link

coveralls commented Dec 12, 2023

Coverage Status

coverage: 85.498% (+0.02%) from 85.478%
when pulling 5079d3f on add-thai-morse
into 3b6daf0 on dev.

@wannaphong
Copy link
Member Author

Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bact bact self-requested a review December 14, 2023 16:21
@wannaphong wannaphong merged commit b3c1143 into dev Dec 15, 2023
16 of 18 checks passed
@bact bact deleted the add-thai-morse branch December 15, 2023 08:38
@bact bact added the enhancement enhance functionalities label Dec 15, 2023
@bact bact added this to the Future milestone Dec 15, 2023
@bact bact added this to Done in PyThaiNLP Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhance functionalities
Projects
PyThaiNLP
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants