Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contributing_models.md #80

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Add contributing_models.md #80

merged 1 commit into from
Sep 12, 2022

Conversation

zhoonit
Copy link
Contributor

@zhoonit zhoonit commented Sep 3, 2022

라이선스 동의

변경해주시는 내용에 BSD 3항 라이선스가 적용됨을 동의해주셔야 합니다.

더 자세한 내용은 기여하기 문서를 참고해주세요.

동의하시면 아래 [ ]를 [x]로 만들어주세요.

  • 기여하기 문서를 확인하였으며, 본 PR 내용에 BSD 3항 라이선스가 적용됨에 동의합니다.

관련 이슈 번호

이 Pull Request와 관련있는 이슈 번호를 적어주세요.

이슈 또는 PR 번호 앞에 #을 붙이시면 제목을 바로 확인하실 수 있습니다. (예. #999 )

PR 종류

이 PR에 해당되는 종류 앞의 [ ]을 [x]로 변경해주세요.

  • 오탈자를 수정하거나 번역을 개선하는 기여
  • 번역되지 않은 모델 소개를 번역하는 기여
  • 공식 허브의 내용을 반영하는 기여
  • 위 종류에 포함되지 않는 기여

PR 설명

model 을 추가하고 싶을 때 참고할 수 있는 페이지를 추가하였습니다.

@zhoonit zhoonit force-pushed the @contributing_models branch 7 times, most recently from f40e4eb to a29dfe3 Compare September 3, 2022 05:54
euroversedev
euroversedev reviewed Sep 3, 2022
View reviewed changes
CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
spongebob03
spongebob03 reviewed Sep 3, 2022
View reviewed changes
Copy link
Contributor

@spongebob03 spongebob03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

template에 대한 리뷰 남깁니다!

docs/template.md Outdated Show resolved Hide resolved
docs/template.md Outdated Show resolved Hide resolved
zerojin91
zerojin91 reviewed Sep 3, 2022
View reviewed changes
Copy link
Contributor

@zerojin91 zerojin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 남깁니다.

CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
CONTRIBUTING_MODELS.md Show resolved Hide resolved
petanerd
petanerd reviewed Sep 3, 2022
View reviewed changes
Copy link
Contributor

@petanerd petanerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

용어와 줄바꿈 관련하여 몇가지 review 남겨드렸습니다.
검토해주시면 감사하겠습니다. :)

CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
zerojin91
zerojin91 reviewed Sep 3, 2022
View reviewed changes
CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
woodywarhol9
woodywarhol9 reviewed Sep 3, 2022
View reviewed changes
Copy link
Contributor

@woodywarhol9 woodywarhol9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역 관련 하나 제안드려요!

CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
JunyongKang
JunyongKang reviewed Sep 3, 2022
View reviewed changes
CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
JunyongKang
JunyongKang reviewed Sep 3, 2022
View reviewed changes
docs/template.md Outdated Show resolved Hide resolved
Lee-JaeWon
Lee-JaeWon reviewed Sep 3, 2022
View reviewed changes
CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
yh00214
yh00214 reviewed Sep 3, 2022
View reviewed changes
CONTRIBUTING_MODELS.md Outdated Show resolved Hide resolved
woodywarhol9
woodywarhol9 reviewed Sep 3, 2022
View reviewed changes
Copy link
Contributor

@woodywarhol9 woodywarhol9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code block 관련해서 리뷰 남깁니다!

28번 라인의 dependencies = ['torch'] 부분은 code block에 들어가야 할 거 같아요.

@zhoonit @songhee23
@HyunKyungHan @JDhyeok @poroblem
Add contributing_models.md
348e9e4 
Co-authored-by: songhee23 <ereteyeu@naver.com>
Co-authored-by: HyunKyungHan <hhk@ewhain.net>
Co-authored-by: JDhyeok <jdhyeok97@gmail.com>
Co-authored-by: poroblem <cheonyujun10@naver.com>
@zhoonit
Copy link
Contributor Author

zhoonit commented Sep 3, 2022

code block 관련해서 리뷰 남깁니다!

28번 라인의 dependencies = ['torch'] 부분은 code block에 들어가야 할 거 같아요.

넵 그러네요! 변경하였습니다 :)

@codingbowoo codingbowoo merged commit 4dc8802 into PyTorchKorea:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songhee23 songhee23 songhee23 left review comments

@petanerd petanerd petanerd left review comments

@yh00214 yh00214 yh00214 left review comments

@spongebob03 spongebob03 spongebob03 left review comments

@JunyongKang JunyongKang JunyongKang left review comments

@JDhyeok JDhyeok JDhyeok left review comments

@Lee-JaeWon Lee-JaeWon Lee-JaeWon left review comments

@woodywarhol9 woodywarhol9 woodywarhol9 left review comments

@zerojin91 zerojin91 zerojin91 left review comments

@HyunKyungHan HyunKyungHan HyunKyungHan left review comments

@euroversedev euroversedev euroversedev left review comments

@Taeyoung96 Taeyoung96 Taeyoung96 approved these changes

Assignees
No one assigned
Labels
OSSCA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contribute Models의 template 작성 및 가이드라인 생성