Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipes/android_native_app_with_custom_op.rst 번역 #416

Merged
merged 1 commit into from
Dec 31, 2021

Conversation

des00
Copy link
Contributor

@des00 des00 commented Dec 25, 2021

라이선스 동의

변경해주시는 내용에 BSD 3항 라이선스가 적용됨을 동의해주셔야 합니다.

더 자세한 내용은 기여하기 문서를 참고해주세요.

동의하시면 아래 [ ][x]로 만들어주세요.

  • 기여하기 문서를 확인하였으며, 본 PR 내용에 BSD 3항 라이선스가 적용됨에 동의합니다.

관련 이슈 번호

이 Pull Request와 관련있는 이슈 번호를 적어주세요.

이슈 또는 PR 번호 앞에 #을 붙이시면 제목을 바로 확인하실 수 있습니다. (예. #999 )

PR 종류

이 PR에 해당되는 종류 앞의 [ ][x]로 변경해주세요.

  • 오탈자를 수정하거나 번역을 개선하는 기여
  • 번역되지 않은 튜토리얼을 번역하는 기여
  • 공식 튜토리얼 내용을 반영하는 기여
  • 위 종류에 포함되지 않는 기여

PR 설명

이 PR로 무엇이 달라지는지 대략적으로 알려주세요.

android_native_app_with_custom_op.rst 번역

@des00 des00 requested a review from 9bow December 25, 2021 12:43
@des00
Copy link
Contributor Author

des00 commented Dec 25, 2021

@ajin-jng 님,
일전에 올리셨던 번역 참조하여 새롭게 번역했습니다.
가능하시다면 리뷰 부탁드립니다.

Copy link
Member

@9bow 9bow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 Android 부분을 자세히 알지 못해 내용에 대한 리뷰보다는 소소한 내용들 위주로 리뷰하였습니다.
보시고 괜찮다고 생각하시는 내용들을 선택적으로 반영 부탁드립니다. 🙇


In this recipe, you will learn:
**번역**: `김현길 <https://github.com/des00>`_ , `Ajin Jeong <https://github.com/ajin-jng>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
@9bow
Copy link
Member

9bow commented Dec 25, 2021

👍

@des00 des00 force-pushed the custom-op branch 2 times, most recently from cacf7b9 to cbfa4d8 Compare December 25, 2021 16:33
@des00
Copy link
Contributor Author

des00 commented Dec 25, 2021

recipes_index.rst 파일에서 header, card_description 번역도 추가했습니다.

@9bow
Copy link
Member

9bow commented Dec 26, 2021

놓치고 있었는데 감사합니다!

@9bow
Copy link
Member

9bow commented Dec 26, 2021

다음 주 중순까지 @ajin-jng 님의 추가 코멘트를 기다려보고 병합하도록 하겠습니다.

Copy link
Contributor

@yoosful yoosful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 깔끔하게 잘 번역된 것 같습니다. 긴 글 번역하시느라 수고하셨습니다!

recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
recipes_source/android_native_app_with_custom_op.rst Outdated Show resolved Hide resolved
translate recipes/android_native_app_with_custom_op.rst from PyTorchKorea#128
elaborate PyTorchKorea#128
also translate recipis_index
@9bow
Copy link
Member

9bow commented Dec 31, 2021

@eric-yoo 님 리뷰 감사합니다. :)

@9bow 9bow merged commit fbe1e52 into PyTorchKorea:master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants