Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Docstrings for tabular data #1115

Merged
merged 12 commits into from
Jan 17, 2022
Merged

Docstrings for tabular data #1115

merged 12 commits into from
Jan 17, 2022

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jan 13, 2022

What does this PR do?

Part of #957

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot removed the has conflicts label Jan 13, 2022
@ethanwharris ethanwharris added Data Pipeline V2 documentation Improvements or additions to documentation labels Jan 13, 2022
@ethanwharris ethanwharris changed the title [WIP] Docstrings for tabular data Docstrings for tabular data Jan 13, 2022
Base automatically changed from feature/refactor_tabular_data to master January 14, 2022 13:48
@mergify mergify bot removed the has conflicts label Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #1115 (403680a) into master (1bbd7d7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
+ Coverage   88.53%   88.55%   +0.01%     
==========================================
  Files         286      286              
  Lines       12950    12954       +4     
==========================================
+ Hits        11465    11471       +6     
+ Misses       1485     1483       -2     
Flag Coverage Δ
unittests 88.55% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/tabular/classification/data.py 96.15% <100.00%> (+0.32%) ⬆️
flash/tabular/regression/data.py 96.15% <100.00%> (+0.32%) ⬆️
flash/tabular/classification/input.py 96.00% <0.00%> (+4.00%) ⬆️
flash/tabular/regression/input.py 95.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbd7d7...403680a. Read the comment docs.

flash/tabular/classification/data.py Outdated Show resolved Hide resolved
flash/tabular/classification/data.py Outdated Show resolved Hide resolved
flash/tabular/regression/data.py Outdated Show resolved Hide resolved
flash/tabular/regression/data.py Outdated Show resolved Hide resolved
@ethanwharris ethanwharris merged commit 116778b into master Jan 17, 2022
@ethanwharris ethanwharris deleted the docs/tabular_data branch January 17, 2022 12:18
@ethanwharris ethanwharris mentioned this pull request Jan 17, 2022
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Data Pipeline V2 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants