Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torch.jit.unused to MetricCollection forward #307

Merged
merged 3 commits into from
Jun 22, 2021

Conversation

simran2905
Copy link
Contributor

Before submitting

  • [NA] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • [NA] Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

The forward function of MetricCollection has *args and **kwargs arguments. Which aren't jit supported. Add torch.jit.unused decorator.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

The forward function of MetricCollection has *args and **kwargs arguments. Which aren't jit supported. Add torch.jit.unused decorator.
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #307 (62c2618) into master (b22d09f) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   96.51%   96.42%   -0.10%     
==========================================
  Files         106      106              
  Lines        3448     3444       -4     
==========================================
- Hits         3328     3321       -7     
- Misses        120      123       +3     
Flag Coverage Δ
Linux 75.84% <100.00%> (+0.01%) ⬆️
Windows 75.84% <100.00%> (+0.01%) ⬆️
cpu 75.84% <100.00%> (-20.62%) ⬇️
gpu 96.42% <100.00%> (+<0.01%) ⬆️
macOS 75.84% <100.00%> (-20.62%) ⬇️
pytest 96.42% <100.00%> (-0.10%) ⬇️
python3.6 ?
python3.8 ?
python3.9 ?
torch1.3.1 ?
torch1.4.0 ?
torch1.9.0 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/collections.py 98.87% <100.00%> (+0.02%) ⬆️
torchmetrics/average.py 83.33% <0.00%> (-12.50%) ⬇️
torchmetrics/metric.py 95.43% <0.00%> (-0.08%) ⬇️
torchmetrics/utilities/prints.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22d09f...62c2618. Read the comment docs.

@Borda Borda added the enhancement New feature or request label Jun 22, 2021
@Borda Borda enabled auto-merge (squash) June 22, 2021 19:05
@mergify mergify bot removed the has conflicts label Jun 22, 2021
@Borda Borda merged commit e6a86d2 into Lightning-AI:master Jun 22, 2021
@simran2905 simran2905 deleted the patch-1 branch June 22, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants