Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename some Image metrics #752

Merged
merged 11 commits into from
Jan 14, 2022
Merged

rename some Image metrics #752

merged 11 commits into from
Jan 14, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 14, 2022

What does this PR do?

unify the name convention for image functions
part of #729

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added refactoring refactoring and code health API / design labels Jan 14, 2022
@Borda Borda added this to the v0.7 milestone Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #752 (7dad89f) into master (d044d33) will increase coverage by 21%.
The diff coverage is 87%.

@@           Coverage Diff           @@
##           master   #752     +/-   ##
=======================================
+ Coverage      74%    94%    +21%     
=======================================
  Files         170    170             
  Lines        6831   6858     +27     
=======================================
+ Hits         5027   6472   +1445     
+ Misses       1804    386   -1418     

@Borda Borda marked this pull request as ready for review January 14, 2022 09:45
@Borda Borda changed the title Refactor/image rename some Image metrics Jan 14, 2022
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small suggestion 😃

torchmetrics/image/lpip_similarity.py Show resolved Hide resolved
@Borda Borda enabled auto-merge (squash) January 14, 2022 11:02
@Borda Borda mentioned this pull request Jan 14, 2022
4 tasks
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@Borda Borda self-assigned this Jan 14, 2022
@mergify mergify bot added the ready label Jan 14, 2022
@Borda Borda disabled auto-merge January 14, 2022 12:50
@Borda Borda disabled auto-merge January 14, 2022 14:20
@Borda Borda merged commit 1d1b7d5 into master Jan 14, 2022
@Borda Borda deleted the refactor/image branch January 14, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API / design ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants