Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SSL transforms to pl_bolts/transforms #905

Merged
merged 37 commits into from May 20, 2023
Merged

Move SSL transforms to pl_bolts/transforms #905

merged 37 commits into from May 20, 2023

Conversation

matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Oct 11, 2022 •
edited

What does this PR do?

Fixes part of #904

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the model label Oct 11, 2022
@matsumotosan matsumotosan reopened this Oct 27, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 27, 2022
@matsumotosan matsumotosan mentioned this pull request Nov 8, 2022
Closed
@matsumotosan matsumotosan marked this pull request as ready for review February 25, 2023 05:36
@mergify mergify bot removed the has conflicts label May 19, 2023
@mergify mergify bot added the ready label May 19, 2023
@mergify mergify bot removed the has conflicts label May 20, 2023
@Borda Borda enabled auto-merge (squash) May 20, 2023 20:58
@Borda Borda merged commit 5669578 into Lightning-Universe:master May 20, 2023
23 of 24 checks passed
@matsumotosan matsumotosan deleted the ssl_transforms branch June 7, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@akihironitta akihironitta Awaiting requested review from akihironitta

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation model ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Central location for transforms
3 participants
@matsumotosan @Borda @otaj