Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated property is_slurm_managing_tasks from accelerator connector #10353

Merged
merged 10 commits into from
Nov 5, 2021
Merged

Remove deprecated property is_slurm_managing_tasks from accelerator connector #10353

merged 10 commits into from
Nov 5, 2021

Conversation

SauravMaheshkar
Copy link
Contributor

@SauravMaheshkar SauravMaheshkar commented Nov 4, 2021 •
edited
Loading

What does this PR do?

Fixes a part of #10312

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yesss !! ☕️

@SauravMaheshkar
Copy link
Contributor Author

Question for the maintainers: 🧐🧐🧐

Should I remove the following as well ??

https://github.com/PyTorchLightning/pytorch-lightning/blob/ce3e63262a7247c1111375b28c90bdd83b42bf3f/pytorch_lightning/trainer/connectors/accelerator_connector.py#L1016-L1042

@SauravMaheshkar SauravMaheshkar marked this pull request as ready for review November 4, 2021 14:37
awaelchli
awaelchli reviewed Nov 4, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@awaelchli awaelchli changed the title Remove deprecated property _slurm_managing_tasks from accelerator connector Remove deprecated property is_slurm_managing_tasks from accelerator connector Nov 4, 2021
@awaelchli awaelchli added deprecation Includes a deprecation refactor labels Nov 4, 2021
@awaelchli awaelchli modified the milestones: v1.5, v1.6 Nov 4, 2021
@awaelchli awaelchli added breaking change Includes a breaking change and removed refactor labels Nov 4, 2021
@mergify mergify bot added the has conflicts label Nov 5, 2021
@SauravMaheshkar
Copy link
Contributor Author

Just to clarify @awaelchli, I should remove the tests as well right ?? AFAIK they're the reason for the failing tests.

@mergify mergify bot removed the has conflicts label Nov 5, 2021
@awaelchli
Copy link
Member

awaelchli commented Nov 5, 2021 •
edited
Loading

Yes @SauravMaheshkar
See my three latest commits. I helped to revert the unintended changes. The only thing you needed to remove were the public attributes for is_slurm_managing_tasks and the corresponding tests. The tests were in place to ensure that the properties are kept and appropriate deprecation message is shown. The PR should now be ready to merge.

awaelchli
awaelchli approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Would you like to do a next PR for the method configure_slurm_ddp?

@awaelchli awaelchli self-assigned this Nov 5, 2021
@SauravMaheshkar
Copy link
Contributor Author

Thanks for the clarification, more than happy to take configure_slurm_dpp next 😁.

@SauravMaheshkar
Copy link
Contributor Author

Taking up configure_slurm_ddp in #10370

@justusschock justusschock enabled auto-merge (squash) November 5, 2021 09:25
@mergify mergify bot added the ready PRs ready to be merged label Nov 5, 2021
tchaton
tchaton approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@justusschock justusschock merged commit 6b5e185 into Lightning-AI:master Nov 5, 2021
@SauravMaheshkar SauravMaheshkar deleted the remove-slurm branch November 5, 2021 09:40
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@SauravMaheshkar @awaelchli
@pre-commit-ci @Raalsky
Remove deprecated property is_slurm_managing_tasks from accelerator…
0d85d77 
… connector (Lightning-AI#10353)

* Remove deprecated property _slurm_managing_tasks from accelerator connector

* Update CHANGELOG

* Update Changelog

* Removed is_slurm_managing_tasks from AcceleratorConnector

* resolve merge conflict

* add back accidentally removed lines

* remove test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
itzsimpl added a commit to itzsimpl/NeMo that referenced this pull request Jan 30, 2024
@itzsimpl
refactor: check_slurm() is always returning false
cb0c070 
is_slurm_managing_tasks was removed from AcceleratorConnector in Lightning 1.6.0, Lightning-AI/pytorch-lightning#10353; checking if `SLURM_STEP_NUM_TASKS` matches trainer.world_size instead.

Signed-off-by: Iztok Lebar Bajec <ilb@fri.uni-lj.si>
@itzsimpl itzsimpl mentioned this pull request Jan 30, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@awaelchli awaelchli

Labels
breaking change Includes a breaking change deprecation Includes a deprecation ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
4 participants
@SauravMaheshkar @awaelchli @tchaton @justusschock