Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LightningCLI changes for jsonargparse>=4.0.0 #10426

Merged
merged 7 commits into from Nov 19, 2021
Merged

LightningCLI changes for jsonargparse>=4.0.0 #10426

merged 7 commits into from Nov 19, 2021

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Nov 9, 2021 •
edited

What does this PR do?

This PR includes changes required in LightningCLI for jsonargparse 4.0.0 and the deprecated parse_as_dict.

Several issues are fixed with the new jsonargparse version though most of them not reported in github. A couple of fixes that were reported:

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@mauvilsa mauvilsa mentioned this pull request Nov 9, 2021
Closed
10 tasks
@mauvilsa mauvilsa changed the title Check backard compatibility with jsonargparse>=4.0.0rc1 Check backward compatibility with jsonargparse>=4.0.0rc1 Nov 9, 2021
@carmocca carmocca mentioned this pull request Nov 16, 2021
Closed
@mauvilsa mauvilsa changed the title Check backward compatibility with jsonargparse>=4.0.0rc1 LightningCLI changes for jsonargparse>=4.0.0 Nov 17, 2021
@mauvilsa mauvilsa marked this pull request as ready for review November 17, 2021 07:16
@awaelchli awaelchli added the lightningcli pl.cli.LightningCLI label Nov 17, 2021
@awaelchli awaelchli added this to the 1.6 milestone Nov 17, 2021
tchaton
tchaton approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/utilities/cli.py Outdated Show resolved Hide resolved
carmocca
carmocca approved these changes Nov 19, 2021
View reviewed changes
pytorch_lightning/utilities/cli.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/cli.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/cli.py Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Nov 19, 2021
@carmocca carmocca enabled auto-merge (squash) November 19, 2021 16:01
ethanwharris
ethanwharris approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@carmocca carmocca merged commit 5d748e5 into Lightning-AI:master Nov 19, 2021
@mauvilsa mauvilsa deleted the jsonargparse-4-backward-compatible branch November 19, 2021 17:31
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@mauvilsa @carmocca
@tchaton @Raalsky
LightningCLI changes for jsonargparse>=4.0.0 (Lightning-AI#10426)
ef81c67 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
lightningcli pl.cli.LightningCLI ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mauvilsa @ethanwharris @carmocca @tchaton @awaelchli