ReduceLROnPlateau bug fix #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
approved these changes
Mar 13, 2020
Borda
added
ready
|
@SkafteNicki pls add note to changelog... then we can go :] |
Codecov Report
@@ Coverage Diff @@
## master #1126 +/- ##
=======================================
+ Coverage 93% 93% +<1%
=======================================
Files 61 61
Lines 2672 2672
=======================================
+ Hits 2472 2477 +5
+ Misses 200 195 -5 |
|
@Borda I have update CHANGELOG now, should be ready for merge now |
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
* bug fix and test * update CHANGELOG.md Co-authored-by: Nicki Skafte <nugginea@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #1114 #1154
During the latest revoke of the learning rate scheduler interface (by me) a small bug related to the
ReduceLROnPlateautype of scheduler was made. This PR solves that bug and adds a test to check for this in the future.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃