-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributing guide #2830
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
changed the title
Update contributing guide [draft]
Update contributing guide [wip]
Aug 4, 2020
edenlightning
changed the title
Update contributing guide [wip]
Update contributing guide
Aug 5, 2020
justusschock
approved these changes
Aug 6, 2020
rohitgr7
reviewed
Aug 6, 2020
rohitgr7
reviewed
Aug 6, 2020
rohitgr7
reviewed
Aug 6, 2020
rohitgr7
reviewed
Aug 6, 2020
rohitgr7
reviewed
Aug 6, 2020
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda
approved these changes
Aug 6, 2020
rohitgr7
reviewed
Aug 6, 2020
rohitgr7
approved these changes
Aug 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #2830 +/- ##
========================================
- Coverage 90% 82% -8%
========================================
Files 78 79 +1
Lines 6921 8231 +1310
========================================
+ Hits 6238 6734 +496
- Misses 683 1497 +814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃