Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guide #2830

Merged
merged 7 commits into from
Aug 6, 2020
Merged

Update contributing guide #2830

merged 7 commits into from
Aug 6, 2020

Conversation

edenlightning
Copy link
Contributor

@edenlightning edenlightning commented Aug 4, 2020

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team August 4, 2020 22:46
@Borda Borda marked this pull request as draft August 4, 2020 23:09
@Borda Borda changed the title Update contributing guide [draft] Update contributing guide [wip] Aug 4, 2020
@Borda Borda added the docs Documentation related label Aug 4, 2020
@nateraw nateraw requested review from nateraw and removed request for nateraw August 5, 2020 03:23
@edenlightning edenlightning changed the title Update contributing guide [wip] Update contributing guide Aug 5, 2020
@edenlightning edenlightning marked this pull request as ready for review August 5, 2020 21:28
@mergify mergify bot requested a review from a team August 6, 2020 06:19
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team August 6, 2020 06:52
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team August 6, 2020 06:53
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team August 6, 2020 06:55
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team August 6, 2020 06:55
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team August 6, 2020 10:07
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team August 6, 2020 10:15
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #2830 into master will decrease coverage by 8%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2830     +/-   ##
========================================
- Coverage      90%     82%     -8%     
========================================
  Files          78      79      +1     
  Lines        6921    8231   +1310     
========================================
+ Hits         6238    6734    +496     
- Misses        683    1497    +814     

@Borda Borda added this to the 0.9.0 milestone Aug 6, 2020
@Borda Borda added the ready PRs ready to be merged label Aug 6, 2020
@Borda Borda merged commit 1dc411f into master Aug 6, 2020
@Borda Borda deleted the edenlightning-patch-1 branch August 6, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants