Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to log momentum #4384

Merged
merged 6 commits into from
Oct 28, 2020

Conversation

jeremyjordan
Copy link
Contributor

What does this PR do?

Adds the ability to optionally log momentum values in the LearningRateMonitor.

I followed the style of the existing code, except instead of saving all momentum values I decided to only save the last value. It seemed like this attribute was only being used for testing so I decided to keep the memory footprint lower.

Fixes #4354

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #4384 into master will increase coverage by 1%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4384   +/-   ##
======================================
+ Coverage      92%     93%   +1%     
======================================
  Files         111     111           
  Lines        8139    8060   -79     
======================================
- Hits         7477    7470    -7     
+ Misses        662     590   -72     

@ydcjeff ydcjeff added the feature Is an improvement or enhancement label Oct 27, 2020
@ydcjeff ydcjeff added this to the 1.1 milestone Oct 27, 2020
@mergify mergify bot requested a review from a team October 27, 2020 14:48
@ydcjeff ydcjeff modified the milestones: 1.1, 1.0.x Oct 28, 2020
@rohitgr7 rohitgr7 merged commit 1e1a422 into Lightning-AI:master Oct 28, 2020
@edenlightning edenlightning modified the milestones: 1.0.x, 1.1 Nov 4, 2020
SeanNaren pushed a commit that referenced this pull request Nov 10, 2020
* add option to log momentum

* add docstring

* refactor for cleanliness

Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
(cherry picked from commit 1e1a422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add momentum to the LearningRateMonitor
7 participants