Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix torchtext data to gpu #4785

Merged
merged 4 commits into from Nov 24, 2020
Merged

Fix torchtext data to gpu #4785

merged 4 commits into from Nov 24, 2020

Conversation

jungwhank
Copy link
Contributor

What does this PR do?

Fixes #4782

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added bug Something isn't working data handling Generic data-related topic labels Nov 20, 2020
@Borda Borda added this to the 1.0.x milestone Nov 20, 2020
@awaelchli
Copy link
Member

Note: #3529

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch !

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #4785 (f8fb92d) into master (7d96fd1) will decrease coverage by 0%.
The diff coverage is 67%.

@@          Coverage Diff           @@
##           master   #4785   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         118     118           
  Lines        9030    9032    +2     
======================================
+ Hits         8403    8404    +1     
- Misses        627     628    +1     

@awaelchli awaelchli added the ready PRs ready to be merged label Nov 23, 2020
@ananyahjha93 ananyahjha93 merged commit 471ca37 into Lightning-AI:master Nov 24, 2020
@jungwhank jungwhank deleted the bugfix/4782_torchtextgpu branch November 24, 2020 05:57
Borda pushed a commit that referenced this pull request Nov 24, 2020
Co-authored-by: chaton <thomas@grid.ai>
(cherry picked from commit 471ca37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data handling Generic data-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError when using None field value in torchtext with GPU
7 participants