Start version suffixes at 1

[carmocca]

What does this PR do?

It is assumed that file.ckpt would correspond to -v0. Chose not to rename it to file-v0.ckpt after the discussion at #5030 (comment)

Fixes #5000

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
• Did you make sure to update the documentation with your changes?
• Did you write any new necessary tests?
• Did you verify new and existing tests pass locally with your changes?
• If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

[pep8speaks]

Hello @carmocca! Thanks for updating this PR.

• In the file pytorch_lightning/callbacks/model_checkpoint.py:

Line 547:13: W503 line break before binary operator
Line 548:13: W503 line break before binary operator
Line 549:13: W503 line break before binary operator

Comment last updated at 2021-01-26 20:07:19 UTC

[Borda]

@carmocca any update here?

[carmocca]

@carmocca any update here?

I implemented a test by calling .fit() twice. But that does not work properly due to #5007, hence why this PR is blocked by that issue.

Otherwise (assuming no bugs when #5007 is solved) it should be ready to review.

[codecov]

Codecov Report

Merging #5008 (b60982a) into release/1.2-dev (dee5553) will decrease coverage by 0%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release/1.2-dev   #5008   +/-   ##
===============================================
- Coverage               93%     93%   -0%     
===============================================
  Files                  154     154           
  Lines                11041   11040    -1     
===============================================
- Hits                 10218   10216    -2     
- Misses                 823     824    +1