accelerator refactor - add parallel plugins #5714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
Borda,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
awaelchli
force-pushed
the
refactor/copy-ddp-plugins
branch
from
50433ee
to
06da4fb
Compare
awaelchli
force-pushed
the
refactor/copy-ddp-plugins
branch
from
06da4fb
to
edbb672
Compare
|
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-31 12:20:10 UTC |
awaelchli
force-pushed
the
refactor/copy-ddp-plugins
branch
from
edbb672
to
e21ebb1
Compare
justusschock
approved these changes
Jan 30, 2021
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
awaelchli
force-pushed
the
refactor/copy-ddp-plugins
branch
from
e21ebb1
to
05f5825
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5714 +/- ##
===============================================
- Coverage 89% 89% -0%
===============================================
Files 169 173 +4
Lines 12415 12339 -76
===============================================
- Hits 11099 11006 -93
- Misses 1316 1333 +17 |
awaelchli
changed the title
SeanNaren
approved these changes
Jan 31, 2021
Borda
approved these changes
Jan 31, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #5616, copy ddp plugins
Should be merged after #5715
There are some TODO comments, these will be addressed when we integrate and write additional tests