Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

try PT 1.8 compatible fairscale #5996

Merged
merged 6 commits into from Feb 16, 2021
Merged

try PT 1.8 compatible fairscale #5996

merged 6 commits into from Feb 16, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 15, 2021

What does this PR do?

Fixing compatibility with fairscale and PT 1.8
cc: @SeanNaren

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added bug Something isn't working priority: 1 Medium priority task labels Feb 15, 2021
@Borda Borda added this to the 1.2 milestone Feb 15, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #5996 (7dfdf58) into master (fcfa7fa) will decrease coverage by 59%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #5996     +/-   ##
========================================
- Coverage      90%     31%    -59%     
========================================
  Files         170     170             
  Lines       11663   11663             
========================================
- Hits        10533    3661   -6872     
- Misses       1130    8002   +6872     

@Borda Borda added the ready PRs ready to be merged label Feb 16, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda changed the title try to extend fairscale available try PT 1.8 compatible fairscale Feb 16, 2021
@Borda Borda merged commit 960a607 into master Feb 16, 2021
@Borda Borda deleted the fix/fairscale-pt-1.8 branch February 16, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants