Updated mac.py to be more simiar to windows.py #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Added diagnostic functionality to PyKeyboardEvent. *Added stop function to mirror windows.py. *Updated escape functionality to handler function. *Added key_code_translate_table for value to key string lookup.
|
I'm a bit hazy on the purpose on Windows of the lookup table. I vaguely remember some discussion about keyboard layouts. But Mac has universal keycodes, so that should not be an issue, I think? Where did you get the values for the table from? It would be nice if the source was listed just as character_translate_table and special_key_translate_table. Even nicer would be to get these values from PyObjC directly, but I'm not sure that's possible. |
|
Actually, it seems to be just the inverse of the other table? And only used in the diagnostics. So why not simply do something like res = dict((v,k) for k,v in a.iteritems()) |
The key_code_translate_table is now generated programmatically by copying and and manipulating the keys and values in character_translate_table.
|
key_code_translate_table is now generated programmatically, in the manner described by @pepijndevos. |
|
Thanks. I invited you to the organization as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Added diagnostic functionality to PyKeyboardEvent.
*Added stop function to mirror windows.py.
*Updated escape functionality to handler function.
*Added key_code_translate_table for value to key string lookup.