Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log formatter should not combine lines starting "[\s*\S+\s*]" #102

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

jsiirola
Copy link
Contributor

Fixes: #N/A

Summary/Motivation:

This prevents the log formatter from combining lines that begin with "\[s*\S+\s*\]", so that log messages like the following are not reformatted:

INFO: The following extensions were downloaded:
        [FAIL]  gsl
        [ OK ]  mcpp

Changes proposed in this PR:

  • Treat lines beginning with "\[\s*[A-Za-z0-9]+\s*\]" as if they were bulleted lists.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 61.923% when pulling ac33f23 on log-formatting into c0b323e on master.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #102 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   63.96%   63.96%           
=======================================
  Files          87       87           
  Lines        8933     8934    +1     
=======================================
+ Hits         5714     5715    +1     
  Misses       3219     3219           
Impacted Files Coverage Δ
pyutilib/misc/log_config.py 97.36% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b323e...ac33f23. Read the comment docs.

@jsiirola jsiirola merged commit 9dec0ac into master Jun 18, 2020
@jsiirola jsiirola deleted the log-formatting branch June 18, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants