-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncategorized tests should not default to expensive #46
Conversation
This PR is meant to seed a discussion around managing test suites. This is a 1-line PR with a fairly significant impact. As such, I am hoping to hear from all the reviewers before we entertain merging it. |
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=======================================
Coverage 64.94% 64.94%
=======================================
Files 87 87
Lines 8726 8726
=======================================
Hits 5667 5667
Misses 3059 3059
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favor of this change in default behavior. Reducing some redundancy in our testing infrastructure seems like a win.
Summary/Motivation:
Currently uncategorized pyutilib.th tests default to "smoke, nightly, expensive". This means that the "expensive" test jobs duplicate all of the tests that the smoke/nightly test jobs have already done, which seems redundant ('all' covers that use case). This PR changes the default so that uncategorized tests are marked as "smoke, nightly," but not expensive. This will reduce the amount of unnecessarily repeated tests in most testing setups.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: