Improvements to import_file() and run_file() #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsiirola Given the nature of these changes, I think it's important to add a few tests to confirm that these changes capture the behavior that motivated the PR. |
|
@whart222: absolutely. Tests added. |
blnicho
approved these changes
Dec 13, 2019
|
Was there a typo in the last test from this PR? It seems to be testing the wrong function.
… On Dec 13, 2019, at 11:28 AM, Bethany Nicholson ***@***.***> wrote:
Merged #70 into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@ghackebeil I'm not sure what you're referring to. Where do you think there's an error? |
ghackebeil
reviewed
Dec 13, 2019
| def test_import_exception(self): | ||
| orig_path = list(sys.path) | ||
| with self.assertRaisesRegexp(RuntimeError, "raised during import"): | ||
| pyutilib.misc.run_file( |
There was a problem hiding this comment.
Should this be calling pyutilib.misc.import_file instead of pytuilib.misc.run_file? The test is on the TestImportFile class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: N/A
Summary/Motivation:
This improves the robustness of
import_file()andrun_file()so that thesys.pathis not left in an altered state in the event that the import raises an exception. This also switches to using tools fromsys.pathfor performing path manipulations (instead of hard-coded/and\characters).Changes proposed in this PR:
sys.pathwhen imports raise exceptions/and\path separator characters.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: