-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to pyutilib.misc.config #88
Conversation
ConfigBlock set_value should use __setitem__
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 63.10% 63.00% -0.10%
==========================================
Files 87 87
Lines 8800 8824 +24
==========================================
+ Hits 5553 5560 +7
- Misses 3247 3264 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it!
Fixes: #N/A
Summary/Motivation:
This PR adds some long-overdue documentation for the ConfigValue / ConfigList / ConfigDict system. As part of this, it resolved some bugs and begins the process to rename ConfigBlock to ConfigDict (both names are currently supported). The documentation was confirmed to build and pass doctests (using the Pyomo Online Docs harness).
Changes proposed in this PR:
ConfigBlock
toConfigDict
ConfigDict.declare_from()
methodConfigDict.set_value()
and__getitem__
for derivedConfigDict
classesdisplay()
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: