-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release times #254
Release times #254
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
+ Coverage 93.98% 94.00% +0.02%
==========================================
Files 63 63
Lines 2460 2469 +9
Branches 214 215 +1
==========================================
+ Hits 2312 2321 +9
+ Misses 49 48 -1
- Partials 99 100 +1
☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
Running a benchmark on VRPTW instances:
This branch 773db8c:
main 7533246:
Hardly any difference, so that's good news. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. A few small comments, but nothing substantial.
@N-Wouda I've implemented your comments. Performance is also OK (see #254 (comment)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR:
Notes:
This keeps the code coverage level up, and helps ensure the changes work as intended.