Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CD also on push to main #544

Merged
merged 9 commits into from
Mar 22, 2024
Merged

Run CD also on push to main #544

merged 9 commits into from
Mar 22, 2024

Conversation

N-Wouda
Copy link
Member

@N-Wouda N-Wouda commented Mar 22, 2024

This PR:

  • fixes a CD build issue on Windows by bumping to CIBW 2.16.5
  • provides a workaround for macOS's inability to handle std::optional::value
  • fixes uploading and downloading artefacts of the same name

Since this stuff's horribly annoying, from now on we're also going to test run the CD every time we push to main.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.98%. Comparing base (75e4fd4) to head (91588a9).
Report is 1 commits behind head on main.

❗ Current head 91588a9 differs from pull request most recent head cd17ded. Consider uploading reports for the commit cd17ded to get more accurate results

Files Patch % Lines
pyvrp/cpp/ProblemData.cpp 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files          73       73           
  Lines        3012     3012           
  Branches      247      247           
=======================================
  Hits         2861     2861           
  Misses         66       66           
  Partials       85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@N-Wouda N-Wouda merged commit 4cf0727 into main Mar 22, 2024
4 of 5 checks passed
@N-Wouda N-Wouda deleted the fix-cd-and-always-run-on-main branch March 22, 2024 15:51
@N-Wouda N-Wouda changed the title Run CD also on pushed to main Run CD also on push to main Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant