Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass dir paths to download functions #87

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Pass dir paths to download functions #87

merged 3 commits into from
Apr 19, 2023

Conversation

leonlan
Copy link
Member

@leonlan leonlan commented Apr 18, 2023

Closes #64.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c4faece) 100.00% compared to head (664df26) 100.00%.

❗ Current head 664df26 differs from pull request most recent head 41c07a3. Consider uploading reports for the commit 41c07a3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #87   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          231       241   +10     
=========================================
+ Hits           231       241   +10     
Impacted Files Coverage Δ
vrplib/download/download_instance.py 100.00% <100.00%> (ø)
vrplib/download/download_solution.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leonlan leonlan changed the title Pass dir to download functions Pass dir paths to download functions Apr 19, 2023
@leonlan leonlan merged commit 57e3e89 into master Apr 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default argument for path in download & allow dirs
1 participant