Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wavelet instance vs string #36

Closed
sciunto opened this issue Sep 30, 2013 · 3 comments
Closed

wavelet instance vs string #36

sciunto opened this issue Sep 30, 2013 · 3 comments
Milestone

Comments

@sciunto
Copy link

sciunto commented Sep 30, 2013

Hi,

In functions.py, intwave and centfreq can receive either a wavelet instance or a string. Should we keep this or should I remove strings as a valid type?

There is the same question for multidim/multilevel actually.

I don't think scipy used to allow two types. @rgommers Thoughts?

@rgommers
Copy link
Member

There are places in scipy where this happens, for example some functions take a scipy.stats distribution instance or a string with the name of a distribution. I propose to leave it as is for now. If this is done consistently in the same way for the wavelet parameter of functions, I don't mind it actually.

@rgommers
Copy link
Member

But anyway the complete API needs review before inclusion into scipy, so if we have a list of stuff like this that would be helpful.

@rgommers
Copy link
Member

rgommers commented Oct 1, 2013

Listed as part of overall API review ticket gh-38. So closing this one.

@rgommers rgommers closed this as completed Oct 1, 2013
@rgommers rgommers modified the milestone: v0.3.0 Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants