ENH: improve iswt performance #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove PyPI classifiers for Python 2.6/3.3 and add 3.6
Current coverage is 86.73% (diff: 100%)@@ master #255 diff @@
==========================================
Files 20 20
Lines 2900 2910 +10
Methods 0 0
Messages 0 0
Branches 277 280 +3
==========================================
+ Hits 2514 2524 +10
Misses 336 336
Partials 50 50
|
credit to @zstomp for suggesting this modification
|
LGTM, merged. Thanks @grlee77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimal changes to
iswtto call the Cythonidwt_axisroutine as opposed to the pythonidwtroutine fixes the majority of the python 0.2.2 vs 0.5.1 performance disparity raised in #157.round-trip results were not previously verified for complex dtypes so I added a test for that. (The changes here require handling the complex types directly in
iswtrather than relying onidwtto do it for us)