ENH: use single precision routines for half-precision inputs #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
reviewed
Jan 16, 2017
| # converted to float64. | ||
| dtypes_in = [np.int8, np.float32, np.float64, np.complex64, np.complex128] | ||
| dtypes_out = [np.float64, np.float32, np.float64, np.complex64, np.complex128] | ||
| from pywt.tests.test_dwt_idwt import dtypes_in, dtypes_out |
There was a problem hiding this comment.
tests is not a submodule (no __init__.py), so this made the tests fail.
|
right. I forgot about that. |
formerly half-precision was converted to double
Current coverage is 86.29% (diff: 100%)@@ master #275 diff @@
==========================================
Files 20 20
Lines 3056 3058 +2
Methods 45 45
Messages 0 0
Branches 525 525
==========================================
+ Hits 2637 2639 +2
+ Misses 369 368 -1
- Partials 50 51 +1
|
|
Agreed, that does make more sense. Merged, thanks @grlee77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to process half-precision inputs using single precision rather than double. It's probably a rare use case, but I think that is a more sensible behavior.