test case for CWT with complex input #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
=======================================
Coverage 83.56% 83.56%
=======================================
Files 21 21
Lines 3322 3322
Branches 564 564
=======================================
Hits 2776 2776
Misses 482 482
Partials 64 64Continue to review full report at Codecov.
|
|
LGTM, thanks @grlee77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A side effect of the DWT-focused #300 was that it also resolved #326 by making
cwtaccept complex dtypes on the inputs. This PR just adds a simple test case to make sure that this feature gets tested to avoid future breakage.I also updated the CWT to avoid a
FutureWarningrelated to #310.