Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling of continuous globally #362

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Mar 15, 2018

@tayebzaidi pointed out another misspelling of continuous than the one recently resolved in #360. A quick grep of the codebase revealed several other instances.

Fortunately, none of these are in function names in the Python API, so there should not be a backwards compatibility concern for PyWavelets itself. Some function names in the underlying C/Cython code were modified, but I don't believe we make any guarantees regarding backward compatibility of the code in the private _extensions folder?

@codecov-io
Copy link

Codecov Report

Merging #362 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   83.55%   83.55%           
=======================================
  Files          21       21           
  Lines        3332     3332           
  Branches      567      567           
=======================================
  Hits         2784     2784           
  Misses        484      484           
  Partials       64       64
Impacted Files Coverage Δ
pywt/_cwt.py 81.25% <ø> (ø) ⬆️
pywt/_extensions/c/wavelets.c 85.74% <100%> (ø) ⬆️
pywt/_extensions/_pywt.pyx 71.48% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073b8e1...809fdaf. Read the comment docs.

@rgommers rgommers merged commit bf7be1f into PyWavelets:master Mar 16, 2018
@rgommers
Copy link
Member

Some function names in the underlying C/Cython code were modified, but I don't believe we make any guarantees regarding backward compatibility of the code in the private _extensions folder?

Indeed, fine to change. Thanks @grlee77, merged.

@rgommers rgommers added this to the v1.0 milestone Mar 16, 2018
@grlee77 grlee77 deleted the fix_continuous_spelling branch July 20, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants