Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove iswt2's restriction on non-square inputs #369

Merged
merged 2 commits into from
May 4, 2018

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Apr 25, 2018

iswt2 enforces square shaped inputs (this is even documented in a comment), but that seems to be unnecessary. This PR just removes the restriction and adds a basic test case with rectangular inputs.

closes #368

@codecov-io
Copy link

Codecov Report

Merging #369 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files          21       21           
  Lines        3332     3332           
  Branches      567      567           
=======================================
  Hits         2785     2785           
  Misses        483      483           
  Partials       64       64
Impacted Files Coverage Δ
pywt/_swt.py 86.77% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c00702...e3a0d59. Read the comment docs.

@grlee77 grlee77 merged commit d7c601d into PyWavelets:master May 4, 2018
@grlee77 grlee77 added this to the v1.0 milestone Jul 18, 2018
@grlee77 grlee77 deleted the iswt2_non_square branch July 20, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in ISWT2 for non-rectangular arrays
2 participants