swap swt2 coefficient order (and remove FutureWarnings) #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swt2 coefficient order is modified to match the convention used by all other discrete transforms in PyWavelets.
grlee77
changed the title
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
==========================================
- Coverage 84.26% 84.25% -0.02%
==========================================
Files 22 22
Lines 3540 3537 -3
Branches 600 600
==========================================
- Hits 2983 2980 -3
Misses 489 489
Partials 68 68
Continue to review full report at Codecov.
|
|
Thanks @grlee77. I think it also needs an entry under "backwards incompatible changes" in the release notes. |
|
LGTM now, merged. Thanks @grlee77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps the
swt2coefficient order to match the convention used by all other discrete transforms in PyWavelets. Release 0.5 added aFutureWarningregarding this pending change. Here the warnings have been removed and the swap has been implemented.closes #81